feat(types): make RegistryTicket.value generic for type safety#53
Merged
johnleider merged 1 commit intomasterfrom Nov 29, 2025
Merged
Conversation
|
commit: |
johnleider
force-pushed
the
claude/review-v0-composables-01Tqph2Zyo8UvD4TEypmcsYD
branch
from
c8d39be to
d5114a7
Compare
This change adds a generic value type parameter to RegistryTicket and propagates it through the entire composable hierarchy: - RegistryTicket<V = unknown> - Base type now accepts value type - SelectionTicket<V> - Inherits from RegistryTicket<V> - SingleTicket<V>, GroupTicket<V>, StepTicket<V> - Selection descendants - FormTicket<V>, QueueTicket<V>, TimelineTicket<V> - Registry extensions - TokenTicket - Uses RegistryTicket<TokenValue> - ThemeTicket - Uses SingleTicket<ThemeColors> - FeatureTicket - Uses GroupTicket<TokenValue> - PermissionTicket - Extends TokenTicket with permission value type Also updates: - TokenPrimitive now includes Function for permission callbacks - Components (SelectionItem, SingleItem, GroupItem, StepItem) use generic V - ThemeRecord no longer uses index signature with `any` This provides: - Full type safety for stored values - IDE autocomplete for ticket.value - Compile-time error detection - Zero runtime cost (types only)
johnleider
force-pushed
the
claude/review-v0-composables-01Tqph2Zyo8UvD4TEypmcsYD
branch
from
d5114a7 to
bf2b568
Compare
johnleider
deleted the
claude/review-v0-composables-01Tqph2Zyo8UvD4TEypmcsYD
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a generic value type parameter to RegistryTicket and
propagates it through the entire composable hierarchy:
Also updates:
anyRecord<string, unknown>instead ofanyThis provides: