refactor: replace computed() with toRef() #21167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaelWD
force-pushed
the
refactor/remove-computed
branch
from
ea9439f to
fec8132
Compare
MajesticPotatoe
added
the
T: enhancement
ikushum
reviewed
Apr 13, 2025
Member
ikushum
left a comment
ikushum
left a comment
There was a problem hiding this comment.
Looking at the number of files changed, is it safe to merge this into master directly?
Member
|
Where is your sense of adventure? |
Member
Just worried about a potential adventurous rollback later 😅 |
Member
Author
|
Should be fine, |
KaelWD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computed refs that are infrequently accessed and don't do anything complex can be replaced with getter refs which saves the setup and caching overhead of computed.
time to render 1000x
<v-btn icon="$vuetify" variant="flat" />:dev: 182ms (189 180 162 176 202)
pr: 139ms (146 136 133 135 144)
Some of these changes might actually hurt performance but I'm not gonna microbenchmark every single one, overall it's a significant improvement.