feat(VDataTable): add new lastFixed property (#21153)#21168
Conversation
5bb1246 to
65efb4c
Compare
lastFixed property|
Rebased to dev since this is a true feature. |
65efb4c to
4fa0f59
Compare
|
It isn't unused, it adds a border to the last fixed column: vuetify/packages/vuetify/src/components/VDataTable/VDataTable.sass Lines 84 to 85 in db9fb77 |
4fa0f59 to
ea2bf1c
Compare
ea2bf1c to
11c8580
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new boolean property, lastFixed, to enable right-fixed column header behavior in VDataTable.
- Adds the lastFixed prop to VDataTableHeaders props.
- Updates the fixed styles logic to account for lastFixed columns by setting proper left/right styles.
Comments suppressed due to low confidence (2)
packages/vuetify/src/components/VDataTable/VDataTableHeaders.tsx:98
- [nitpick] The updated condition treats a column with either 'fixed' or 'lastFixed' identically. Verify if a column might inadvertently have both properties set and if their combined effect should be differentiated.
if (!(props.sticky || props.fixedHeader) && !(column.fixed || column.lastFixed)) return undefined
packages/vuetify/src/components/VDataTable/VDataTableHeaders.tsx:103
- Using the same 'fixedOffset' for right-fixed columns may limit flexibility if differing offsets are needed for left versus right positioning. Consider introducing a separate offset for right-fixed columns if applicable.
right: column.lastFixed ? convertToUnit(column.fixedOffset ?? 0) : undefined,
|
Is it possible to not change the interface? Like it's still setting |
johnleider
left a comment
There was a problem hiding this comment.
This needs language in VDataTableHeaders.json, and also newIn.json
I played around with it last time Isias but I could not get it work with the |
446a831 to
5d5d60a
Compare
Added entries on the said files John thanks!
this is to ensure that the header will still be sticky for last fixed
chore(VDataTableHeaders): add entry to new-in.json
5d5d60a to
3254530
Compare
vuetifyjs#21168)" This reverts commit 5e1d653.
Description
Utilize props
lastFixedand make column header fixed on the right.