-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
feat(location-strategies): infinite loop on update location #21229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnleider
previously requested changes
Apr 7, 2025
Member
Contributor
Author
Member
|
Did you build Vuetify before running the docs? |
John I have updated this and checked using the build command that we discussed, let me know if there are still problems.
fix(location-strategies): partially fix bug #20515 fix(location-strategies): set max retry to 2 fix(location-strategies): save the last x and y position fix(location-strategies): add comments fix(location-strategies): remove unnecessary code
fix(location-strategies): move increment of retries inside the function fix(location-strategies): increase retries to x3
0a766f4 to
7c53e68
Compare
feat: reduce position left of the over on final reposition
Member
|
Different approach that only checks for flipping in the resize observer and doesn't potentially introduce another infinite loop by unterminated |
Contributor
Author
|
Close this PR to a more better solution from Kael. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




Description
Reduce the number of reposition to a max of
2, if we only set it to1it will be a little off the mark with the correct position and size. This is to prevent infinite reposition, and to make it settle to a certain location after the max retries we need to pass a location to the childVMenufor example:menu-props={ location: "top"}after 2 tries of reposition and resizing it will settle at the top. See the example here: #21098.If you guys are okay with this enhancement or you have a better idea on how to tackle this problem let me know thanks!
On this VPlay add the
location: "top"to see and test.