fix(VSelect): dont open menu on its own when items change #21247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvi-nagaraj
force-pushed
the
fix/menu-opening-issue
branch
3 times, most recently
from
4df6d8c to
41fabae
Compare
MajesticPotatoe
added
T: bug
Contributor
Author
|
@MajesticPotatoe can I get a review on this please? |
arvi-nagaraj
force-pushed
the
fix/menu-opening-issue
branch
from
41fabae to
4b37cde
Compare
Contributor
Author
|
@KaelWD @MajesticPotatoe This PR is still pending review. Could you please take a look when you get a chance? |
arvi-nagaraj
force-pushed
the
fix/menu-opening-issue
branch
from
4b37cde to
63127cb
Compare
arvi-nagaraj
force-pushed
the
fix/menu-opening-issue
branch
from
63127cb to
c9a61f6
Compare
KaelWD
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vuetifyjs/vuetify#21205
This PR addresses an issue where the dropdown would open on its own when items changed.
Solution
The dropdown is now conditionally opened only when hideNoData is true, preventing it from appearing unnecessarily always.