Skip to content

Conversation

@jcjp
Copy link
Contributor

@jcjp jcjp commented Apr 13, 2025

Description

Markup:

<template>
  <v-combobox
    auto-scroll
    v-model="value"
    :items="items"
    label="Default"
    auto-select-first
  />
</template>

<script>
  export default {
    data: () => ({
      items: [
        'bar',
        'buzz',
        'fi1',
        'fi2',
        'fi3',
        'fi4',
        'fi5',
        'fi6',
        'fizz',
        'foo',
      ],
      value: 'foo',
    }),
  }
</script>

@jcjp jcjp marked this pull request as draft April 13, 2025 10:36
@jcjp jcjp force-pushed the fix(VComboxbox)/on-search-first-result-hidden branch 2 times, most recently from 94ed7fc to 6039afd Compare April 13, 2025 10:39
@jcjp jcjp requested review from Spatlani and johnleider April 13, 2025 10:40
@jcjp jcjp self-assigned this Apr 13, 2025
@jcjp jcjp marked this pull request as ready for review April 13, 2025 11:37
@johnleider
Copy link
Member

Feature requests should go to dev branch.

@jcjp jcjp changed the base branch from master to dev April 18, 2025 13:38
@jcjp
Copy link
Contributor Author

jcjp commented Apr 18, 2025

Feature requests should go to dev branch.

Thanks John pointed to dev now.

@jcjp jcjp requested review from ikushum and nekosaur April 25, 2025 13:07
@jcjp jcjp force-pushed the fix(VComboxbox)/on-search-first-result-hidden branch from 6039afd to 4b1a739 Compare May 3, 2025 12:22
@jcjp jcjp requested a review from Copilot May 3, 2025 12:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a fix for issue #20572 by ensuring that the first search result item is visible in the VCombobox component.

  • Automatically scrolls to the first item after a search in single selection mode.
  • Updates the VCombobox to call the virtual scroll component's scrollToIndex method.

@johnleider johnleider added this to the v3.9.0 (Zealot) milestone May 13, 2025
@jcjp jcjp force-pushed the fix(VComboxbox)/on-search-first-result-hidden branch from e6fc0f3 to 717a243 Compare May 18, 2025 05:47
@jcjp jcjp merged commit 57bb5ad into dev May 18, 2025
18 checks passed
@jcjp jcjp deleted the fix(VComboxbox)/on-search-first-result-hidden branch May 18, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] [V-Combobox] scroll to the item which will automatically selected if auto-select-first is true

4 participants