Skip to content

Conversation

@johnleider
Copy link
Member

@johnleider johnleider commented Apr 14, 2025

Pending: lerna/lerna#4055

@johnleider johnleider self-assigned this Apr 14, 2025
also added prospective patch for versioning issues
@johnleider johnleider force-pushed the chore/use-pnpm-catalogs branch from a753dc8 to a6db801 Compare April 14, 2025 17:01
@johnleider johnleider added the upstream Problem with a third party library that we may have to work around label Apr 14, 2025
@KaelWD
Copy link
Member

KaelWD commented Apr 15, 2025

This also breaks pnpm update: https://pnpm.io/catalogs#caveats

@userquin
Copy link
Member

userquin commented Apr 15, 2025

Maybe using https://github.com/antfu-collective/taze , supports pnpm catalog and named catalogs

Comment on lines +84 to +86
"@mdi/js@7.4.47": "/home/john/sites/vuetify/patches/@mdi__js@7.4.47.patch",
"@testing-library/vue": "/home/john/sites/vuetify/patches/@testing-library__vue.patch",
"vue-gtag-next": "/home/john/sites/vuetify/patches/vue-gtag-next.patch"
Copy link
Member

@userquin userquin Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove /home/john/sites/vuetify/ prefix here, should be relative.

We also need to update to pnpm 10.8.1, pnpm patch fixed in this release: https://github.com/pnpm/pnpm/releases

@ghiscoding
Copy link

ghiscoding commented May 6, 2025

If you don't need or care about Nx, then you could also switch to use Lerna-Lite as an alternative (which I maintain and is closer to the original Lerna code, before Nx came in). Lerna-Lite fully supports Workspace and Catalog protocols which was added a few months ago and it also works with both lerna version & publish commands (see Lerna-Lite catalog: docs).

For more info about Lerna-Lite itself, you can read this small section on the main readme, the commands are pretty much the same and so nothing new to learn. Lastly, both Workspace and Catalog protocols are purposely used within Lerna-Lite itself to make sure that everything runs smoothly (I made some fixes related to catalog as recently as last week and it's now used by VuePress ecosystem/themes projects with catalog, even Jest & Volar projects use Lerna-Lite)

Cheers

@ghiscoding
Copy link

ghiscoding commented Sep 13, 2025

I see that @KaelWD migrated the project to Lerna-Lite in this commit 7ce2ce6 to now only use and rely on lerna version to bump the versions. So with that in place, you guys can now officially switch to pnpm catalog: without any problems... you're welcome 😉

I'm the maintainer of Lerna-Lite and if it's useful to you then upvoting it would be nice 😄 I might add your project to the list of big users (you would become the 2nd biggest user after Jest, so thank you). I also saw that I missed the lerna clean command, I might add it in the future, it seems simple enough (EDIT: I worked on the clean command, but then realized that the clean command is probably easier to deal with other simpler tools and so I won't add it to Lerna-Lite).

Also pnpm update is now supported in pnpm since June of this year in v10.12.x (see this pnpm PR feat: support catalog: protocol on pnpm update)

Cheers

@ghiscoding
Copy link

ghiscoding commented Sep 27, 2025

I know you guys have your own way of publishing with OIDC but I'm happy to say that both Lerna and Lerna-Lite now support OIDC Trusted Publishing, see Lerna-Lite@4.9.0 with a working demo: https://github.com/lerna-lite-test/oidc

Combine that with Catalogs and life is good 😄

@johnleider johnleider marked this pull request as ready for review September 27, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream Problem with a third party library that we may have to work around

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants