-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
chore: use pnpm catalog to manage dependencies #21259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
also added prospective patch for versioning issues
a753dc8 to
a6db801
Compare
|
This also breaks |
|
Maybe using https://github.com/antfu-collective/taze , supports pnpm catalog and named catalogs |
| "@mdi/js@7.4.47": "/home/john/sites/vuetify/patches/@mdi__js@7.4.47.patch", | ||
| "@testing-library/vue": "/home/john/sites/vuetify/patches/@testing-library__vue.patch", | ||
| "vue-gtag-next": "/home/john/sites/vuetify/patches/vue-gtag-next.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove /home/john/sites/vuetify/ prefix here, should be relative.
We also need to update to pnpm 10.8.1, pnpm patch fixed in this release: https://github.com/pnpm/pnpm/releases
|
If you don't need or care about Nx, then you could also switch to use Lerna-Lite as an alternative (which I maintain and is closer to the original Lerna code, before Nx came in). Lerna-Lite fully supports Workspace and Catalog protocols which was added a few months ago and it also works with both lerna version & publish commands (see Lerna-Lite For more info about Lerna-Lite itself, you can read this small section on the main readme, the commands are pretty much the same and so nothing new to learn. Lastly, both Workspace and Catalog protocols are purposely used within Lerna-Lite itself to make sure that everything runs smoothly (I made some fixes related to catalog as recently as last week and it's now used by VuePress ecosystem/themes projects with catalog, even Jest & Volar projects use Lerna-Lite) Cheers |
142b234 to
bb54746
Compare
|
I see that @KaelWD migrated the project to Lerna-Lite in this commit 7ce2ce6 to now only use and rely on I'm the maintainer of Lerna-Lite and if it's useful to you then upvoting it would be nice 😄 I might add your project to the list of big users (you would become the 2nd biggest user after Jest, so thank you). I also saw that I missed the Also Cheers |
|
I know you guys have your own way of publishing with OIDC but I'm happy to say that both Lerna and Lerna-Lite now support OIDC Trusted Publishing, see Lerna-Lite@4.9.0 with a working demo: https://github.com/lerna-lite-test/oidc Combine that with Catalogs and life is good 😄 |
Pending: lerna/lerna#4055