Skip to content

Conversation

@KaelWD
Copy link
Member

@KaelWD KaelWD commented Apr 15, 2025

@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected E: validation labels Apr 16, 2025
@KaelWD KaelWD marked this pull request as ready for review May 15, 2025 10:31
@KaelWD KaelWD added labs Must be completed for this component to leave labs E: rules labels May 15, 2025
@KaelWD KaelWD added this to the v3.8.x milestone May 15, 2025
@KaelWD KaelWD self-assigned this May 15, 2025
@KaelWD KaelWD changed the title fix(validation): resolve global rules feat(validation): resolve global rules May 15, 2025
@KaelWD KaelWD merged commit 27e72f5 into master May 15, 2025
18 checks passed
@KaelWD KaelWD deleted the kaelwd/treeshake-rules branch May 15, 2025 10:39
@kohenkatz
Copy link
Contributor

Should there be a documentation update that goes with this change?

The example code for useRules in the documentation and the 3.8.0 release blog post no longer works after this commit.

The call to const rules = useRules() throws error TS2554: Expected 1 arguments, but got 0 and the use of rules.required() throws Error TS2339: Property 'required' does not exist on type 'any[] | readonly (string | boolean | PromiseLike<ValidationResult> | ((value: any) => ValidationResult) | ((value: any) => PromiseLike<ValidationResult>) | [...])[]'.

@laventnc
Copy link

I'm confused, the composable no longer works and I don't see any guidance on how to get it working

@laventnc
Copy link

If anyone is here and curious about getting this working, check my comment on the linked issue report ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

E: rules E: validation labs Must be completed for this component to leave labs T: bug Functionality that does not work as intended/expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants