-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
refactor(VRipple): Use PointerEvent to fix some bugs #21469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Solve this problem using PointerEvent. fixes vuetifyjs#21468
|
We don't support anything without PointerEvent anyway: https://vuetifyjs.com/en/getting-started/browser-support/ |
I am not familiar with Vitest, and I don't know how to fix the tests. I hope you can help me. |
|
It would need to be verified on an actual device, but when simulating the pinch-zoom (holding |
@J-Sek I believe this is a bug in Chromium. I tested Edge, Chrome, and Cent Browser on Windows. When simulating a device, holding down the shift key and moving the mouse does not trigger Fortunately, Chromium on Android does not have this issue. I tested Edge, Chrome, and Cromite on Android, and when scaling begins, they stop responding to Firefox on Android also does not have this issue, as it responds with a The previous code worked correctly because it cancels the animation as soon as After testing again, I found that there is a certain probability of triggering the ripple effect during mobile scaling. One solution is to increase the |
|
Thanks for putting the time for manual verification. Once E2E tests are green I will double-check and we should be ready for merge. |
6ba1568 to
142b234
Compare
Description
fixes #21468In newer browsers,
PointerEventcan be used instead ofMouseEventandTouchEvent.Compatibility list: https://caniuse.com/?search=PointerEvent
Changes
KeyboardEvent.keyCodewith the updatedKeyboardEvent.keyand fixed an error inkeyValues.New Bugs
Markup: