Skip to content

Conversation

@ikushum
Copy link
Member

@ikushum ikushum commented Jun 3, 2025

fixes #10890
fixes #3618
fixes #9028
fixes #4484

Description

Created a new component v-mask-input.
This PR has been continued from #19207

Markup:

<template>
  <v-app>
    <v-container>
      <v-card>
        <v-card-title>
          <h1>Mask</h1>
        </v-card-title>

        <v-card-text>
          <v-text-field v-model="mask" label="Mask"></v-text-field>
        </v-card-text>
      </v-card>

      <br />
      <br />

      <v-card>
        <v-card-title>
          <h1>prop: returnMaskedValue = false</h1>
          <h3>v-model: {{ value }}</h3>
        </v-card-title>

        <v-card-text>
          <VMaskInput
            v-model="value"
            :mask="mask"
            label="Value"
          />
        </v-card-text>
      </v-card>

      <br />
      <br />

      <v-card>
        <v-card-title>
        <h1>prop: returnMaskedValue = true</h1>
        <h3>v-model: {{ value1 }}</h3>
        </v-card-title>

        <v-card-text>
          <VMaskInput
            returnMaskedValue
            v-model="value1"
            :mask="mask"
            label="Value"
          />
        </v-card-text>
      </v-card>
    </v-container>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'

  const mask = ref('(###) ### - ####')
  const value = ref('4443331111')
  const value1 = ref('4443331111')
</script>

@ikushum ikushum requested review from KaelWD and johnleider June 3, 2025 18:30
@ikushum ikushum force-pushed the feat/VMaskInput branch 2 times, most recently from 91e8fa0 to c0bbef4 Compare June 4, 2025 05:31
@ikushum ikushum requested review from J-Sek and KaelWD June 4, 2025 05:32
J-Sek
J-Sek previously approved these changes Jun 4, 2025
@ikushum ikushum changed the base branch from feat/v3-mask-port-v1 to dev June 5, 2025 06:32
@ikushum ikushum dismissed J-Sek’s stale review June 5, 2025 06:32

The base branch was changed.

@ikushum ikushum force-pushed the feat/VMaskInput branch from c0bbef4 to ff46663 Compare June 5, 2025 06:46
@ikushum ikushum requested review from a team and J-Sek June 5, 2025 06:50
@J-Sek
Copy link
Contributor

J-Sek commented Jun 5, 2025

Nice to have (maybe follow-up, possible in user-land):

image

Quick draft: 8d46f5e
Note: I think it would make sense to move it inside composable and replace all tokens (default and custom) with _

johnleider
johnleider previously approved these changes Jun 7, 2025
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing. Great spread of information, unit tests, and clean code. I think the only area that could use some love would be more examples, like a lot. Maybe @MajesticPotatoe or @eesayas could chip in.

@J-Sek J-Sek self-requested a review June 8, 2025 13:17
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the unit tests being fixed (if any of them are even related to this P.R.)

@ikushum ikushum merged commit 117443a into dev Jun 11, 2025
18 checks passed
@ikushum ikushum deleted the feat/VMaskInput branch June 11, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants