refactor: migrate observer composables to @vuetify/v0#22672
Merged
johnleider merged 14 commits intonextfrom Mar 10, 2026
Merged
refactor: migrate observer composables to @vuetify/v0#22672johnleider merged 14 commits intonextfrom
johnleider merged 14 commits intonextfrom
Conversation
ShallowRef<HTMLElement | null> is not assignable to MaybeRef<Element | null | undefined> due to [RefSymbol] branding incompatibility between @vue/reactivity 3.5.24 (v0) and 3.5.25 (vuetify). Also migrates Marquee.vue from deleted resizeObserver composable to native ResizeObserver.
Replace internal useIntersectionObserver, useResizeObserver, and useMutationObserver with useElementIntersection and useElementSize from @vuetify/v0. Removes 3 composables, 2 test files, and the @types/resize-observer-browser dev dependency. Components updated: VInfiniteScroll, VOtpInput, VParallax, VProgressCircular. Composables updated: layout, virtual.
v0@0.1.5 uses structural MaybeElementRef types that accept cross-version Vue refs without casts. Remove all 18 as any casts from useElementSize, useElementIntersection, and useResizeObserver call sites.
Fixes CI typecheck error where shallowRef<HTMLElement | null> is not assignable to VNodeRef in template :ref bindings.
This comment was marked as resolved.
This comment was marked as resolved.
- if you need `as any` you're doing it wrong - `ref<foo | null>(null)` can just be `ref<foo>()` - `watch(() => ref.value)` can just be `watch(ref)`
KaelWD
changed the title
J-Sek
previously approved these changes
Mar 4, 2026
This was referenced Mar 11, 2026
KaelWD
reviewed
Mar 11, 2026
| const { isIntersecting } = useElementIntersection(el) | ||
|
|
||
| watch(isIntersecting, async val => { | ||
| watch(() => isIntersecting.value, async val => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useIntersectionObserver,useResizeObserver, anduseMutationObserverwithuseElementIntersection,useElementSize, anduseResizeObserverfrom@vuetify/v0@^0.1.5@types/resize-observer-browserdev dependencyMutationOptionsinterface inline intodirectives/mutate/index.tsuseTemplateReffor element refs@vuetify/v0tominimumReleaseAgeExcludein pnpm-workspace.yamlComponents updated
useElementIntersectionuseElementIntersectionuseElementIntersection+useElementSizeuseElementIntersection+useElementSizeuseElementIntersection+useResizeObserveruseElementSizeuseResizeObserveruseResizeObserveruseResizeObserveruseResizeObserveruseElementSizeuseResizeObserverComposables updated
layout.ts —useElementSize(replacesuseResizeObserver)useElementSize(replacesuseResizeObserver)Test plan
pnpm testpasses (only pre-existing date adapter failures remain)pnpm lint:fixand typecheck passResizeObservererrors in browser tests