Moment fix #72
Merged
Moment fix #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM Let us check if it works and we will merge it |
Contributor
Author
|
Replace every yyyy-mm-dd basically with YYYY-MM-DD |
Member
Believe me or not, but it isn't that hard to understand your 2 lines of code, you don't need to explain :) |
maxidragon
approved these changes
Jun 25, 2024
Member
maxidragon
left a comment
maxidragon
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Contributor
Author
|
Update it on npmjs too :) |
Member
|
New version (3.5.4) will be available on npm in a few minutes edit: published ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #71
The formats was in lowercase and prevented dateFrom and dateTo from working