Skip to content

Ensuring the CookieOption struct's fields are exported #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2019
Merged

Ensuring the CookieOption struct's fields are exported #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe05a5f
ensuring the CookieOption struct's fields are exported (#174)
gheibia Jun 6, 2019
39fb088
dep ensuring
gheibia Jun 6, 2019
e52616d
Updating failing test, I should pay more attention
gheibia Jun 6, 2019
255ab78
dep ensuring has caused problems, reverting. Although this is really …
gheibia Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions roundrobin/stickysessions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ type StickySession struct {

// CookieOptions has all the options one would like to set on the affinity cookie
type CookieOptions struct {
httpOnly bool
secure bool
HTTPOnly bool
Secure bool
}

// NewStickySession creates a new StickySession
Expand Down Expand Up @@ -53,7 +53,7 @@ func (s *StickySession) GetBackend(req *http.Request, servers []*url.URL) (*url.
// StickBackend creates and sets the cookie
func (s *StickySession) StickBackend(backend *url.URL, w *http.ResponseWriter) {
opt := s.options
cookie := &http.Cookie{Name: s.cookieName, Value: backend.String(), Path: "/", HttpOnly: opt.httpOnly, Secure: opt.secure}
cookie := &http.Cookie{Name: s.cookieName, Value: backend.String(), Path: "/", HttpOnly: opt.HTTPOnly, Secure: opt.Secure}
http.SetCookie(*w, cookie)
}

Expand Down
2 changes: 1 addition & 1 deletion roundrobin/stickysessions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func TestStickCookieWithOptions(t *testing.T) {
fwd, err := forward.New()
require.NoError(t, err)

options := CookieOptions{httpOnly: true, secure: true}
options := CookieOptions{HTTPOnly: true, Secure: true}
sticky := NewStickySessionWithOptions("test", options)
require.NotNil(t, sticky)

Expand Down