fix: initialize Multibuf Response Writer before Reader #251
Merged
ldez merged 3 commits intovulcand:masterfrom Apr 18, 2026
Merged
fix: initialize Multibuf Response Writer before Reader #251ldez merged 3 commits intovulcand:masterfrom
ldez merged 3 commits intovulcand:masterfrom
Conversation
Contributor
Author
|
looking to close traefik/traefik#11568 with this |
|
@ldez any chance you can review this? |
ldez
force-pushed
the
encoding-size-500s
branch
from
cbc65e6 to
09d0ac9
Compare
ldez
changed the title
ldez
changed the title
ldez
approved these changes
Apr 18, 2026
vliska
pushed a commit
to vliska/oxy
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will resolve #240 and as such, I've added @vincentob's test case.
The multibuf library appears to keep their own internal state of the
Writerobject. The 500s we were seeing were to to theWritercallingReader()when it's still in thewriterInitstate.We can see that here: Multibuf Buffer We can avoid this by initializing the writer by calling
Writer().They handle the writerInit case in the writer function here
Fixes #240