docs(rfc): propose MCP client integration design#307
Open
mason5052 wants to merge 2 commits intovxcontrol:feature/next-releasefrom
Open
docs(rfc): propose MCP client integration design#307mason5052 wants to merge 2 commits intovxcontrol:feature/next-releasefrom
mason5052 wants to merge 2 commits intovxcontrol:feature/next-releasefrom
Conversation
Signed-off-by: mason5052 <ehehwnwjs5052@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adds a docs-only RFC proposing a staged design for integrating external Model Context Protocol (MCP) servers as a first-class tool source in PentAGI, using Burp Suite Pro MCP as a motivating example. This is intended to set explicit-by-default boundaries (allowlists, namespacing, auditability, safety) before any runtime implementation work begins.
Changes:
- Introduces an RFC describing a proposed v1 MCP client design (configuration model, transports, discovery, namespacing, invocation/audit semantics).
- Includes an illustrative Burp Suite MCP setup example plus security/observability considerations and open questions.
- Proposes a narrow, reviewable first milestone sequence (discovery → allowlisted execution → Burp operator guide).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Reword PR vxcontrol#268 references to talk about review feedback rather than the PR being rejected. - Clarify host.docker.internal availability: not universally provided by the core compose stack; Docker Desktop typically resolves it, while Linux/operator-managed compose stacks may need an explicit extra_hosts: host.docker.internal:host-gateway entry or another controlled endpoint. - Make the safe initial Burp example unambiguously read-only: drop start_active_scan from the illustrative allowlist and call out that active capabilities belong to a later, explicitly gated milestone with scope and approval controls. - Rephrase the awkward 'PentAGI must not be inferred...' sentence for clarity. Signed-off-by: mason5052 <ehehwnwjs5052@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a single docs-only RFC at
examples/proposals/mcp_client_integration.mdthat proposes how PentAGI could support external Model Context Protocol (MCP) servers as a first-class tool source, with Burp Suite Pro MCP as the motivating example from #296. No runtime, dependency, GraphQL/REST schema, generated, compose, or installer changes are included. The implementation work is intentionally deferred so the design can be reviewed first.Problem
Issue #296 proposes a generic MCP client and, in its current form, leans toward auto-discovering and exposing every MCP-advertised tool to every agent by default. That direction has the same shape as the patterns pushed back on during PR #268 review: implicit lifecycle, weak operator visibility, and limited operator control over what agents can reach. Before any MCP runtime lands, a written design surface is needed so the maintainer team can push back on shape, scope, transport, and security boundaries.
Solution
Add one new proposal document under the maintainer's relocated proposals path (
examples/proposals/, established in commit47de4e4and used byevidence_chain.mdandosint-integration-scenarios.md). The RFC is structured into the following sections:Notable framing choices in the RFC:
mcp.<server>.<tool>), bounded timeouts and payload sizes, secret redaction, and audit parity with native tools.mcp-serverrepo from the issue body and sketches how a host-side Burp instance could be reached from the Kali container viahost.docker.internal, with active scan tools gated behind allowlist plus target scope.Schema, GraphQL, REST, and UI implications are explicitly deferred to a later implementation PR rather than pre-decided here.
User Impact
Test Plan
git diff --statshows exactly one new file,examples/proposals/mcp_client_integration.md.git diff --checkis clean (no whitespace errors).Refs #296