fix(providers): clarify misleading docker image LLM error (#312)#320
Merged
asdek merged 1 commit intoMay 31, 2026
Merged
Conversation
) Fixes vxcontrol#312 Root cause: During flow creation the first LLM call selects the primary Docker image. When the configured LLM backend is unsupported or returns 404, prv.Call fails, but the wrapped error read "failed to get primary docker image". Users repeatedly interpreted this as a Docker problem (see vxcontrol#312, vxcontrol#309, vxcontrol#203) and debugged Docker instead of their LLM provider configuration. Solution: Reword the wrapped error to "failed to select primary docker image via llm call" so the LLM provider is identified as the failing component while still mentioning the image selection step. Testing: go build ./pkg/providers/ -> OK
1f7b5e0 to
94ec0a0
Compare
Contributor
|
hey @mrigankad thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #312
Problem
On a fresh setup, creating any flow fails with:
Because the message says "primary docker image", users (and several issues — #312, #309, and #203) spend time debugging Docker, image pulls, and the registry. The actual failure is unrelated to Docker.
Root Cause
In
NewFlowProvider(backend/pkg/providers/providers.go), the first LLM call during flow creation asks the configured provider to select a primary Docker image:When the configured LLM backend is unsupported or misconfigured,
prv.Callreturns the provider's HTTP404. The error is wrapped with wording that points at Docker rather than the LLM provider, so the underlying404looks like a Docker registry error. As maintainers have noted on #312/#309, the 404 originates from the LLM backend.Solution
Reword the wrapped error so the failing component (the LLM call) is identified, while still naming the image-selection step:
One-line message change; no behavioral change.
Testing
Risk Assessment
Minimal. Only the text of a wrapped error string changes; no control flow, signatures, or behavior are affected. The substring
primary docker imageis retained, so any log scraping keyed on that phrase keeps matching.