T8595: add AGENTS.md + Copilot symlink for the vyos-org central Mergify baseline#11
T8595: add AGENTS.md + Copilot symlink for the vyos-org central Mergify baseline#11andamasov wants to merge 2 commits into
Conversation
…fy baseline Authority: T8595 (AGENTS.md fleet rollout). 🤖 Generated by [robots](https://vyos.io)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📜 Recent review details🧰 Additional context used🧠 Learnings (1)📓 Common learnings🪛 LanguageToolAGENTS.md[locale-violation] ~26-~26: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects. (AFTERWARDS_US) 🔍 Remote MCP Context7Summary of additional, review-relevant facts
Relevant implications for this PR
Tools/sources used
🔀 Multi-repo context ansible/ansibleLinked repositories findingsansible/ansible
🔇 Additional comments (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds ChangesOrganization Mergify baseline documentation
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@copilot review |
Both the project-purpose summary (line 5) and the Conventions note (line 38) incorrectly stated `ignore_conflicts: false`; .mergify.yml has had `ignore_conflicts: true` (with label_conflicts + assignees as compensating controls) since the incident post-mortem. Update both lines to match. Agent-Logs-Url: https://github.com/vyos/mergify/sessions/68cbfb22-2a97-46af-b2fd-4161c6236f74 Co-authored-by: andamasov <12631358+andamasov@users.noreply.github.com>
Review complete. One real finding fixed (8642233):
Everything else looks correct:
|
|
@copilot review |
No new findings. Current state (HEAD
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Summary
Adds
AGENTS.mdat repo root with a.github/copilot-instructions.mdsymlink to../AGENTS.md, completing AGENTS.md fleet coverage for the vyos-org central Mergify baseline.Content diverges from
VyOS-Networks/mergify— see "Cross-repo context" for the rationale on the unified single-rule shape used here (vs the two-rule shape on the Networks side).Authority: T8595, with T8782 / IS-432 context.
Local CodeRabbit (Phase 0 per WD-1334): 2 findings, both classified as symlink-deref false positives — CodeRabbit reviewed
.github/copilot-instructions.mdas if it were a standalone file rather than a symlink to../AGENTS.md. Findings flagged "heading mismatch" and "Parent (this file) phrasing"; in AGENTS.md (the actual file) both are correct. Pushback rather than edit.Test plan
@copilot review) is clean🤖 Generated by robots