Allow @VyOS-Networks/maintainers to run Mergify commands#5
Merged
Conversation
Add `sender=@VyOS-Networks/maintainers` to the shared `commands_restrictions` block so VyOS-Networks Maintainers can issue @Mergifyio slash commands when this central config (or any per-repo config copying its conditions) is encountered on the VyOS-Networks side of the cross-org mirror. Mergify evaluates each `or:` branch independently. A team reference from a different org evaluates to a non-match with a surfaced warning ("Team @<org>/<team> is not part of the organization <repo-org>") but does not fail the rule. So on vyos org PRs, `@vyos/maintainers` still matches normally and the cross-org entry is benign. Incident: VyOS-Networks/vyatta-cfg#33. The T8531-era inline config in `.github/mergify.yml` only listed `@vyos/maintainers`, and after the cross-org mirror pipeline replicated it to VyOS-Networks, `@Mergifyio backport` from a VyOS-Networks Maintainer was rejected. Pairs with vyos/vyatta-cfg#134 (migration to `extends: mergify`) and the matching change to VyOS-Networks/mergify. 🤖 Generated by [robots](https://vyos.io)
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughLines 94–120 of ChangesBackport Authorization Configuration
Possibly related PRs
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
@copilot review |
1 similar comment
Member
Author
|
@copilot review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add `sender=@VyOS-Networks/maintainers` to the shared `commands_restrictions` block so VyOS-Networks Maintainers can issue @Mergifyio slash commands on the VyOS-Networks side of the cross-org mirror pipeline.
Why
Incident: VyOS-Networks/vyatta-cfg#33. The T8531 predecessor inline config in vatta-cfg's `.github/mergify.yml` only listed `@vyos/maintainers`. The cross-org mirror pipeline replicated it byte-for-byte to `VyOS-Networks/vyatta-cfg`, where the team reference is cross-org and Mergify rejected `@Mergifyio backport circinus` from VyOS-Networks Maintainers with:
This PR addresses the central baseline. Defense-in-depth: any per-repo config copying these conditions to a VyOS-Networks repo without migrating to `extends:` will still accept commands from VyOS-Networks Maintainers.
Behavior on vyos/* PRs
Mergify evaluates each `or:` branch independently. The cross-org team reference evaluates to a non-match with a surfaced warning but does not fail the rule. So on vyos repo PRs:
Related
🤖 Generated by robots