Skip to content

Conversation

@alkersan
Copy link
Contributor

@alkersan alkersan commented Aug 30, 2019

Please review another portion of 'trivial' rewrites from vyatta-op. Also see the corresponding PR in vyatta-op.

Notes and questions:

  • monitor bandwidth-test initiate | accept rewritten as is
  • generate ssh-server-key was rewritten in simple python script
  • show history rewritten as is
  • show host os rewritten as is
  • show host date rewritten as is
  • set terminal <misc opt> rewritten as is
  • format disk like rewritten into python and merged with show disk definitions
  • set <tag> was moved to set builtin <tag>, as top-level tagNodes aren't allowed

How this was tested:

  • A QEMU VM image was built from the rolling vyos-1.2-rolling-201908301331-amd64.iso
  • each rewritten command was executed manually after vyos-1x and vyatta-op deb packages re-install

@alkersan alkersan marked this pull request as ready for review August 30, 2019 15:59
@c-po c-po merged commit b25d8e9 into vyos:current Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants