Skip to content

Conversation

@sever-sever
Copy link
Member

Add trace feature for ipv4 ipv6 vrf

vyos@r4-roll:~$ monitor traceroute 
Possible completions:
  <hostname>    Monitor path to destination in realtime
  <x.x.x.x>
  <h:h:h:h:h:h:h:h>
  ipv4          IPv4 fully qualified domain name (FQDN)
  ipv6          IPv6 fully qualified domain name (FQDN)
  vrf           Monitor path to destination in realtime via given VRF

@jack9603301
Copy link
Contributor

<node name="monitor">
<children>
<tagNode name="traceroute">
<properties>
<help>Monitor path to destination in realtime</help>
<completionHelp>
<list>&lt;hostname&gt; &lt;x.x.x.x&gt; &lt;h:h:h:h:h:h:h:h&gt;</list>
</completionHelp>
</properties>
<command>/usr/bin/mtr "$3"</command>
</tagNode>
<node name="traceroute">
<children>
<tagNode name="vrf">
<properties>
<help>Monitor path to destination in realtime via given VRF</help>
<completionHelp>
<path>vrf name</path>
</completionHelp>
</properties>
<children>
<!-- we need an empty tagNode to pass in a plain fqdn/ip address and
let traceroute decide how to handle this parameter -->
<tagNode name="">
<properties>
<help>Track network path to specified node via given VRF</help>
<completionHelp>
<list>&lt;hostname&gt; &lt;x.x.x.x&gt; &lt;h:h:h:h:h:h:h:h&gt;</list>
</completionHelp>
</properties>
<command>sudo /usr/sbin/ip vrf exec "$4" /usr/bin/mtr "$5"</command>
</tagNode>
</children>
</tagNode>
</children>
</node>
</children>
</node>

I feel that your implementation is duplicated with the following code

@jack9603301
Copy link
Contributor

If possible, code should be added to the above file

@c-po
Copy link
Member

c-po commented Aug 18, 2020

@sever-sever please merge your changes into op-mode-definitions/traceroute.xml

@sever-sever
Copy link
Member Author

@sever-sever please merge your changes into op-mode-definitions/traceroute.xml

@c-po Done.

@c-po c-po merged commit 01609e0 into vyos:current Aug 18, 2020
@sever-sever sever-sever deleted the T2791 branch January 25, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants