Skip to content

Conversation

@dmsimard
Copy link
Contributor

@dmsimard dmsimard commented Nov 24, 2021

SUMMARY

Depends-On: #220
.swp files are VI temporary files and it was likely not intended to be
added to the repository.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

tests

@GomathiselviS
Copy link
Contributor

@dmsimard Thanks for working on this. Can you please add a changelog fragment?

@dmsimard
Copy link
Contributor Author

dmsimard commented Dec 1, 2021

@dmsimard Thanks for working on this. Can you please add a changelog fragment?

@GomathiselviS is it really necessary ? This removes an unused file that was added by mistake.

@GomathiselviS
Copy link
Contributor

@dmsimard Thanks for working on this. Can you please add a changelog fragment?

@GomathiselviS is it really necessary ? This removes an unused file that was added by mistake.

@dmsimard Yes. For now, any changes made under plugins and tests directory require a changelog. Otherwise , ansible-changelog-fragment test fails.

.swp files are VI temporary files and it was likely not intended to be
added to the repository.
@GomathiselviS
Copy link
Contributor

recheck

@GomathiselviS GomathiselviS added the gate Gate PR in Zuul CI label Dec 8, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit be096e9 into vyos:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gate Gate PR in Zuul CI

Development

Successfully merging this pull request may close these issues.

2 participants