T7162: interface preflight

[gaige]

Change Summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe): test fixes

Related Task(s)

https://vyos.dev/T7162

Related PR(s)

Component(s) name

vyos_interfaces

Proposed changes

Changes to ensure that tests work correctly and thoroughly. Require the use of e1000e in a virtual environment as the virtio interfaces don't have all the functionality that the e1000e does.

How to test

ansible-test network-integration --inventory `pwd`/inventory.network vyos_interfaces 

Test results

• Sanity tests passed
• Unit tests passed

Tested against VyOS versions:

• 1.3.8
• 1.4.1
• 1.5-rolling-202502030007

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the ansible sanity and unit tests
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added unit tests to cover my changes
• I have added a file to changelogs/fragments to describe the changes

[omnom62]

Looks ok to me

[omnom62]

@gaige I see you are adding the preflight details directly via _populate commands?
If so, then should we also add creating bond2 where this is required (almost all vyos*interfaces targets - l3, lag, ospf etc?

[gaige]

@gaige I see you are adding the preflight details directly via _populate commands? If so, then should we also add creating bond2 where this is required (almost all vyos*interfaces targets - l3, lag, ospf etc?

Yes, with the caveat that we should only add them where necessary. However, the l3 and lag interface tests should already be functioning properly (adding their prerequisites and removing them as necessary).

With that said, although the lag and l3 interface tests were working before, they are now failing after doing this change, so I'm going to throw it back into draft and take another look. They still work on the main branch for me, so I think there's some dependency on the difference between the prior and current initializers.

I need to look at this later,though.

[omnom62]

`ansible-test network-integration --inventory hosts vyos_interfaces
Running vyos_interfaces integration test role

PLAY [vyos] ********************************************************************
...

PLAY RECAP *********************************************************************
target138 : ok=132 changed=20 unreachable=0 failed=0 skipped=19 rescued=0 ignored=5
target142 : ok=132 changed=19 unreachable=0 failed=0 skipped=19 rescued=0 ignored=5
target15x : ok=133 changed=20 unreachable=0 failed=0 skipped=18 rescued=0 ignored=5

`
Looking good