bugfix/replacing-deprecated-size-function#102
Closed
mbramwell1 wants to merge 4 commits intovypdev:masterfrom
Closed
bugfix/replacing-deprecated-size-function#102mbramwell1 wants to merge 4 commits intovypdev:masterfrom
mbramwell1 wants to merge 4 commits intovypdev:masterfrom
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/vypdev/zstandard~102 Documentation is deployed and generated using docs.page. |
Member
|
Sorry for the delay. I would like to merge your contribution. @mbramwell1 |
Author
|
No problem. I had to revisit this a bit so closed the PR whilst I did (got a new mac to test on and realised it still wasn't working). The PR as it is now should be good to go, tested on my mac now. |
1 task
15 tasks
Member
|
Could you test this? @mbramwell1 dependencies:
zstandard:
git:
url: https://github.com/vypdev/zstandard.git |
Author
|
@efraespada looks good to me, just picked up v1.5.0 and all working as expected. Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing the deprecated getDecompressedSize with the new getFrameContentSize.
getDecompressedSize has been removed from MacOS 26+