Fix for lost connections with RabbitMQ #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as lost or became corrupted.
vyuldashev
reviewed
Jun 29, 2017
|
|
||
| // If it's set to false, throw an error rather than waiting | ||
| if ($this->sleepOnError === false) { | ||
| throw new \Exception('Error writing data to the connection with RabbitMQ'); |
Owner
There was a problem hiding this comment.
Probably changing Exception to RuntimeException will make better sense?
Author
There was a problem hiding this comment.
Sure, that's fine. I've applied the change.
Owner
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, if a queue worker is running while a connection error happens to RabbitMQ, the worker becomes corrupted and cannot process data correctly anymore.
The job being run by the worker is never marked as failed, it also does not work anymore even if the connection to RabbitMQ is restored.
This fix allows to optionally throw an exception if this scenario happens and the worker will be killed by Laravel.
Then if used along with Supervisor, a new worker is spawned and new connection will be established allowing the system to work again.