Skip to content

editorial: [aria.js] populate global states&props lists in pre-processing#2766

Draft
pkra wants to merge 1 commit intomainfrom
ariajs20260410
Draft

editorial: [aria.js] populate global states&props lists in pre-processing#2766
pkra wants to merge 1 commit intomainfrom
ariajs20260410

Conversation

@pkra
Copy link
Copy Markdown
Member

@pkra pkra commented Apr 10, 2026

🚀 Netlify Preview:
🔄 this PR updates the following sspecs:

  • ARIA previewARIA diff

  • index.html

    • roletype role characteristics table
      • replace placeholder span with empty ul with data attribute
    • Global States and Properties section
      • replace placeholder p with empty ul with data attribute
  • common/script/aria.js

    • remove buildGlobalStatesAndPropertiesList()
    • remove renderIndexGlobalStatesAndProperties()
    • ariaAttributeReferences()
      • remove calls to both of the above
  • common/script/ariaPreprocessing.js

    • add buildGlobalStatesAndPropertiesLists()
      • a merger of the two functions from aria.js
      • uses HTML markup directly/only to generate list items
    • ariaPreprocessing()
      • call buildGlobalStatesAndPropertiesLists() with relevant placeholders
      • clean up placeholder markup

Part of #2501

…sing

- index.html
  - roletype role characteristics table
    - replace placeholder span with empty ul with data attribute
  - Global States and Properties section
    - replace placeholder p with empty ul with data attribute
- common/script/aria.js
  - remove buildGlobalStatesAndPropertiesList()
  - remove renderIndexGlobalStatesAndProperties()
  - ariaAttributeReferences()
    - remove calls to both of the above
- common/script/ariaPreprocessing.js
  - add buildGlobalStatesAndPropertiesLists()
    - a merger of the two functions from aria.js
    - uses HTML markup directly/only to generate list items
  - ariaPreprocessing()
    - call buildGlobalStatesAndPropertiesLists() with relevant placeholders
    - clean up placeholder markup

Part of #2501
@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Apr 10, 2026
@pkra pkra marked this pull request as ready for review April 10, 2026 13:36
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 10, 2026

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 45639f7
🔍 Latest deploy log https://app.netlify.com/projects/wai-aria/deploys/69d8fccbfbb6da0008c5172a
😎 Deploy Preview https://deploy-preview-2766--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Deployed on https://deploy-preview-2766--wai-aria.netlify.app

@pkra
Copy link
Copy Markdown
Member Author

pkra commented Apr 10, 2026

The only change in the final spec markup is an additional abbr around ARIA 1.2. This is introduced by respec now that these are generated before respec runs.

A rough local diff

8421c8421
< <li><a href="https://w3c.github.io/aria/#aria-disabled" class="state-reference"><code>aria-disabled (state)</code></a> (Global use deprecated in ARIA 1.2)</li>
---
> <li><a href="https://w3c.github.io/aria/#aria-disabled" class="state-reference"><code>aria-disabled (state)</code></a> (Global use deprecated in <abbr title="Accessible Rich Internet Applications">ARIA</abbr> 1.2)</li>
8423c8423
< <li><a href="https://w3c.github.io/aria/#aria-errormessage" class="property-reference"><code>aria-errormessage</code></a> (Global use deprecated in ARIA 1.2)</li>
---
> <li><a href="https://w3c.github.io/aria/#aria-errormessage" class="property-reference"><code>aria-errormessage</code></a> (Global use deprecated in <abbr title="Accessible Rich Internet Applications">ARIA</abbr> 1.2)</li>
8426c8426
< <li><a href="https://w3c.github.io/aria/#aria-haspopup" class="property-reference"><code>aria-haspopup</code></a> (Global use deprecated in ARIA 1.2)</li>
---
> <li><a href="https://w3c.github.io/aria/#aria-haspopup" class="property-reference"><code>aria-haspopup</code></a> (Global use deprecated in <abbr title="Accessible Rich Internet Applications">ARIA</abbr> 1.2)</li>
8428c8428
< <li><a href="https://w3c.github.io/aria/#aria-invalid" class="state-reference"><code>aria-invalid (state)</code></a> (Global use deprecated in ARIA 1.2)</li>
---
> <li><a href="https://w3c.github.io/aria/#aria-invalid" class="state-reference"><code>aria-invalid (state)</code></a> (Global use deprecated in <abbr title="Accessible Rich Internet Applications">ARIA</abbr> 1.2)</li>
12261c12261
< <li><a href="https://w3c.github.io/aria/#aria-disabled" class="state-reference"><code>aria-disabled (state)</code></a> (Global use deprecated in ARIA 1.2)</li>
---
> <li><a href="https://w3c.github.io/aria/#aria-disabled" class="state-reference"><code>aria-disabled (state)</code></a> (Global use deprecated in <abbr title="Accessible Rich Internet Applications">ARIA</abbr> 1.2)</li>
12263c12263
< <li><a href="https://w3c.github.io/aria/#aria-errormessage" class="property-reference"><code>aria-errormessage</code></a> (Global use deprecated in ARIA 1.2)</li>
---
> <li><a href="https://w3c.github.io/aria/#aria-errormessage" class="property-reference"><code>aria-errormessage</code></a> (Global use deprecated in <abbr title="Accessible Rich Internet Applications">ARIA</abbr> 1.2)</li>
12266c12266
< <li><a href="https://w3c.github.io/aria/#aria-haspopup" class="property-reference"><code>aria-haspopup</code></a> (Global use deprecated in ARIA 1.2)</li>
---
> <li><a href="https://w3c.github.io/aria/#aria-haspopup" class="property-reference"><code>aria-haspopup</code></a> (Global use deprecated in <abbr title="Accessible Rich Internet Applications">ARIA</abbr> 1.2)</li>
12268c12268
< <li><a href="https://w3c.github.io/aria/#aria-invalid" class="state-reference"><code>aria-invalid (state)</code></a> (Global use deprecated in ARIA 1.2)</li>
---
> <li><a href="https://w3c.github.io/aria/#aria-invalid" class="state-reference"><code>aria-invalid (state)</code></a> (Global use deprecated in <abbr title="Accessible Rich Internet Applications">ARIA</abbr> 1.2)</li>

@pkra
Copy link
Copy Markdown
Member Author

pkra commented Apr 10, 2026

Sigh. Once again I forgot to double check roleInfo generation. Moving this back to draft PR.

@pkra pkra mentioned this pull request Apr 10, 2026
28 tasks
Copy link
Copy Markdown
Contributor

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pkra for working on this.

@daniel-montalvo daniel-montalvo marked this pull request as draft April 16, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:aria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants