clear matched impressions after using for L1 norm computation#407
Merged
clear matched impressions after using for L1 norm computation#407
Conversation
The first computation with matched impressions is really just computing the L1 norm. After that we want to clear it otherwise there may be data left in it when we go on to the forward loop over epochs and if the budget checks don't pass we will not add anything to it but it could still have entries it in if we don't clear it here.
apasel422
requested changes
Apr 21, 2026
apasel422
approved these changes
Apr 21, 2026
|
|
||
| 1. If |isSingleEpoch| is true: | ||
| 1. Set |matchedImpressions| to the result of invoking [=common matching logic=] | ||
| 1. Let |impressions| to the result of invoking [=common matching logic=] |
Member
There was a problem hiding this comment.
Suggested change
| 1. Let |impressions| to the result of invoking [=common matching logic=] | |
| 1. Let |impressions| be the result of invoking [=common matching logic=] |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first computation with matched impressions is really just computing the L1 norm. After that we want to clear it otherwise there may be data left in it when we go on to the forward loop over epochs and if the budget checks don't pass we will not add anything to it but it could still have entries it in if we don't clear it here.
Preview | Diff