Define parallel activation for attribution#413
Open
martinthomson wants to merge 3 commits intomainfrom
Open
Conversation
This replicates much of the logic for transient activation, but rather than tracking the state on each Window, this tracks it in the top-level traversable (think browser tab). The explanation is longer than the algorithms, but hopefully that means I don't need to repeat the rationale here. I've gone with a bit of an unconventional method for monkey-patching the navigate algorithm. I think that this is more robust than the normal method of identifying concrete steps. I'd be interested in feedback on whether this is more comprehensible than other monkey-patching approaches. I despise monkey patching, but it seems unavoidable given the architecture of the specifications involved; hence my desire to find something less repugnant. Closes #378.
martinthomson
commented
Apr 29, 2026
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
bmcase
reviewed
May 4, 2026
| This should be no less than the [=transient activation duration=], | ||
| though a larger value | ||
| might be advisable to ensure that delays from [=navigate|navigation=] | ||
| do not cause the Attribution API to become inaccessible. |
Contributor
There was a problem hiding this comment.
I think when we had discussed and drafted something for user activation before, it was that case that when there was a user initiated navigation to a site the API would remain activated for that site at least for that session (with some site level enabled flag). Is that changing if the duration is the same as the transient activation duration which is only a few seconds?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replicates much of the logic for transient activation, but rather than tracking the state on each Window, this tracks it in the top-level traversable (think browser tab).
The explanation is longer than the algorithms, but hopefully that means I don't need to repeat the rationale here.
I've gone with a bit of an unconventional method for monkey-patching the navigate algorithm. I think that this is more robust than the normal method of identifying concrete steps. I'd be interested in feedback on whether this is more comprehensible than other monkey-patching approaches. I despise monkey patching, but it seems unavoidable given the architecture of the specifications involved; hence my desire to find something less repugnant.
Closes #378.
Preview | Diff