Align clip-path checking more closely with spec#110
Merged
Conversation
sideshowbarker
force-pushed
the
sideshowbarker/clip-path
branch
2 times, most recently
from
cbfbfcd to
c90d2fe
Compare
sideshowbarker
force-pushed
the
sideshowbarker/clip-path
branch
2 times, most recently
from
bf337c2 to
022cd11
Compare
sideshowbarker
force-pushed
the
sideshowbarker/clip-path
branch
from
022cd11 to
1ae166b
Compare
This change brings `clip-path` checking a bit closer into alignment with the requirements in https://drafts.fxtf.org/css-masking-1/#the-clip-path. Even with this change, the checker still doesn’t recognize circle(), ellipse() or polygon() values for clip-path, but it does now recognize inset() values — with the limitation of not yet recognizing the `round <‘border-radius’>` optional argument.
sideshowbarker
force-pushed
the
sideshowbarker/clip-path
branch
from
1ae166b to
66c7157
Compare
…tions needs implementations
sideshowbarker
commented
Jan 20, 2018
Member
Author
sideshowbarker
left a comment
sideshowbarker
left a comment
There was a problem hiding this comment.
Reviewed all changes. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change brings
clip-pathchecking a bit closer into alignment with therequirements in https://drafts.fxtf.org/css-masking-1/#the-clip-path.
Even with this change, the checker still doesn’t recognize circle(), ellipse()
or polygon() values for clip-path, but it does now recognize inset() values —
with the limitation of not yet recognizing the
round <‘border-radius’>optional argument.