Allow preprocessing of the input stream to be skipped#382
Merged
Conversation
sideshowbarker
force-pushed
the
sideshowbarker/preprocessing-skipping-allow
branch
2 times, most recently
from
4efeabc to
01656fe
Compare
This change adds an optional isPreprocessed boolean parameter to the StyleSheetParser() constructor; if the value of that parameter is true, the steps from https://drafts.csswg.org/css-syntax/#input-preprocessing for preprocessing the input stream are skipped — so UnescapeFilterReader() is not called. This is useful in a context where the input stream has already been preprocessed — for example, if the contents of the stylesheet being parsed are from an HTML document that has already been parsed by a conformant HTML parser (which is the case, for example, when the https://github.com/validator/validator HTML checker calls the code).
sideshowbarker
force-pushed
the
sideshowbarker/preprocessing-skipping-allow
branch
from
01656fe to
e63c99b
Compare
ylafon
reviewed
Oct 30, 2022
Member
ylafon
left a comment
ylafon
left a comment
There was a problem hiding this comment.
Would be better to fix the pre-processing if needed, as pre-processing twice shouldn't change as it should be idempotent, but ok to have it as an interim solution.
sideshowbarker
deleted the
sideshowbarker/preprocessing-skipping-allow
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an optional
isPreprocessedboolean parameter to theStyleSheetParser()constructor; if the value of that parameter is true, the steps from https://drafts.csswg.org/css-syntax/#input-preprocessing for preprocessing the input stream are skipped — soUnescapeFilterReader()is not called.This is useful in a context where the input stream has already been preprocessed — for example, if the contents of the stylesheet being parsed are from an HTML document that has already been parsed by a conformant HTML parser (which is the case, for example, when the https://github.com/validator/validator HTML checker calls the code).