Skip to content

Conversation

@gkellogg
Copy link
Member

@gkellogg gkellogg commented Apr 7, 2015

This fixes #446.

@JeniT, this can probably be resolved before the telecon, as I don't think it's controversial. You may want to fix any annotation definitions that don't align with your thoughts.

gkellogg added 2 commits April 7, 2015 10:09
Rename column about/property/valueURL to same convention used for cells and reference the cell definition.
@JeniT
Copy link

JeniT commented Apr 8, 2015

I think the metadata document needs to be updated to ensure that the new annotations are populated correctly. @gkellogg do you want to have a go on that or shall I?

@gkellogg gkellogg assigned gkellogg and unassigned JeniT Apr 8, 2015
@gkellogg
Copy link
Member Author

gkellogg commented Apr 8, 2015

This should be ready now, @JeniT. Note that we may want to remove ordered and table direction annotations on the cell as they duplicate those on the column. If so, we need to update the metadata definitions of those properties too.

@gkellogg
Copy link
Member Author

gkellogg commented Apr 8, 2015

... Alternatively, not create column annotations, and just use the cell annotations.

@gkellogg gkellogg assigned JeniT and unassigned gkellogg Apr 8, 2015
…ed-property-annotations

# Conflicts:
#	syntax/index.html
@gkellogg
Copy link
Member Author

gkellogg commented Apr 9, 2015

Merging to simplify PR #469, but will keep issue #457 open for review.

gkellogg added a commit that referenced this pull request Apr 9, 2015
…ions

Issue 446 inherited property annotations
@gkellogg gkellogg merged commit 7ed85ea into gh-pages Apr 9, 2015
@gkellogg gkellogg deleted the issue-446-inherited-property-annotations branch April 12, 2015 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inherited property annotations on columns

3 participants