Skip to content

Improve table accessibility#10

Merged
nigelmegitt merged 2 commits intomainfrom
issue4_fix
Mar 31, 2022
Merged

Improve table accessibility#10
nigelmegitt merged 2 commits intomainfrom
issue4_fix

Conversation

@nigelmegitt
Copy link
Copy Markdown
Contributor

@nigelmegitt nigelmegitt commented Mar 30, 2022

  • Add scope attribute to each table header cell
  • Add table caption
  • Remove unnecessary colspan and rowspan attributes that were just set to 1, which is the default.

This addresses the remainder of #4 as far as I am aware.


Preview | Diff

Also remove unnecessary `colspan` and `rowspan` attributes that were just set to 1, which is the default.
Copy link
Copy Markdown

@andreastai andreastai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me!

@nigelmegitt nigelmegitt merged commit 0b90d6a into main Mar 31, 2022
@nigelmegitt nigelmegitt deleted the issue4_fix branch March 31, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants