Make PS4 apply to dubbing#18
Merged
nigelmegitt merged 1 commit intomainfrom Sep 16, 2022
Merged
Conversation
Closes #4
cconcolato
approved these changes
Sep 16, 2022
Contributor
cconcolato
left a comment
cconcolato
left a comment
There was a problem hiding this comment.
Given that step 4 and 5 both potentially apply to both workflows, if we should not have them sequential: step 5 right after recording to adjust the text (would actually become step 4), and step 4 (which would become step 5) to add mixing instructions.
Contributor
Author
|
That feels like a separate issue - also I think they can happen in either order? |
|
Constraining step order is not good.. I see these as Examples of steps. In reality, the 'Default' mixing instructions are included from the script creation step (e.g. transcript or translate, depending on workflow), and tweaked anywhere in the process (e.g. recording or voicing the element changes the default fade length to match). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
Preview | Diff