[FIX]: legal-kr links broken after brackets removal

[bact]

Specs

LEGAL (e.g. IE, US)

Errors

Ref to commit 92f1ca4 that removed brackets for links to Korean laws in legal-kr.

While there is one link that can be resolved without specifying the Act number and the Act enactment/amendment date, another two will failed.

Term	Original URL	URL without brackets	URL without brackets accessible?
law-PIPA	https://www.law.go.kr/영문법령/개인정보 보호법/(19234,20230314)	https://www.law.go.kr/영문법령/개인정보 보호법/	No
law-CIA	https://www.law.go.kr/영문법령/신용정보의 이용 및 보호에 관한 법률/(19234,20230314)	https://www.law.go.kr/영문법령/신용정보의 이용 및 보호에 관한 법률/	No
law-LIA	https://www.law.go.kr/영문법령/위치정보의 보호 및 이용 등에 관한 법률/(18517,20211019)	https://www.law.go.kr/영문법령/위치정보의 보호 및 이용 등에 관한 법률/	Yes

Note that all URLs above contain spaces and this can make parsers in general work incorrectly. So may be it's better to encode the URLs.

Term	Original URL with space and non-ASCII characters	Encoded URL
law-PIPA	https://www.law.go.kr/영문법령/개인정보 보호법/(19234,20230314)	https://www.law.go.kr/%EC%98%81%EB%AC%B8%EB%B2%95%EB%A0%B9/%EA%B0%9C%EC%9D%B8%EC%A0%95%EB%B3%B4%20%EB%B3%B4%ED%98%B8%EB%B2%95/(19234,20230314)
law-CIA	https://www.law.go.kr/영문법령/신용정보의 이용 및 보호에 관한 법률/(19234,20230314)	https://www.law.go.kr/%EC%98%81%EB%AC%B8%EB%B2%95%EB%A0%B9/%EC%8B%A0%EC%9A%A9%EC%A0%95%EB%B3%B4%EC%9D%98%20%EC%9D%B4%EC%9A%A9%20%EB%B0%8F%20%EB%B3%B4%ED%98%B8%EC%97%90%20%EA%B4%80%ED%95%9C%20%EB%B2%95%EB%A5%A0/(19234,20230314)
law-LIA	https://www.law.go.kr/영문법령/위치정보의 보호 및 이용 등에 관한 법률/(18517,20211019)	https://www.law.go.kr/%EC%98%81%EB%AC%B8%EB%B2%95%EB%A0%B9/%EC%9C%84%EC%B9%98%EC%A0%95%EB%B3%B4%EC%9D%98%20%EB%B3%B4%ED%98%B8%20%EB%B0%8F%20%EC%9D%B4%EC%9A%A9%20%EB%93%B1%EC%97%90%20%EA%B4%80%ED%95%9C%20%EB%B2%95%EB%A5%A0/(18517,20211019)

[coolharsh55]

Thanks @bact - its the brackets and the comma the code uses to separate multiple urls as here -

dpv/code/vocab_funcs.py

Line 239 in 92f1ca4

if url.endswith(')'):

I think I can manage to hack it so we can use that url with the brackets as is. The spaces are not an issue.

[coolharsh55]

@bact fixed it by encoding the urls in the spreadsheet so that '(' and ',' don't appear directly. The links now work as expected. Also that was the wrong code snippet -- we have a separate function for linking webpages to legal concepts (uses foaf:page). Output can be tested at https://dev.dpvcg.org/legal/kr

[TallTed]

Note that ( and ) are not brackets.

Collectively, they are parentheses, and each alone is a parenthesis.

Referring to them as brackets is likely to cause confusion.

[coolharsh55]

@TallTed they are (round) brackets in british english - https://en.wikipedia.org/wiki/Bracket

[TallTed]

I stand corrected. Nonetheless, I would advise referring to them more specifically as either "round brackets" or "parentheses" to avoid confusion with the myriad brackets in the wild.

[bact]

Links on https://dev.dpvcg.org/legal/kr/ work as expected. Will close this issue.