Clean up deactivating EditContext#123
Open
ltenmoz wants to merge 1 commit intow3c:gh-pagesfrom
Open
Conversation
ltenmoz
force-pushed
the
fixup-active-editcontext
branch
from
54efe3f to
47353fa
Compare
ltenmoz
force-pushed
the
fixup-active-editcontext
branch
from
47353fa to
8436570
Compare
Contributor
Author
|
Hmm I think CI is broken (or there's something wrong with this PR, but the error message is not very helpful…) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe deactivate-an-editcontext should only run when the EditContext actually changes (as written, it would run on every update-the-rendering when an EditContext is active…)
Also I think compositionend should only be fired during deactivation if is composing is true (as Chrome currently does)