setMediaKeys(): move state changes and promise resolution to queued t…#596
Open
xhwang-chromium wants to merge 1 commit into
Open
setMediaKeys(): move state changes and promise resolution to queued t…#596xhwang-chromium wants to merge 1 commit into
xhwang-chromium wants to merge 1 commit into
Conversation
de94348 to
c410b71
Compare
Contributor
Author
|
@marcoscaceres Could you please take a look to see whether makes sense? I mechanically did this change (with the help of AI) to make sure matches the existing spec. Could you please take a look to see if it makes sense? Here's a more readable summary for easier discussion: |
…ask (w3c#585) The setMediaKeys() algorithm in Section 7.2 of the EME specification performed several state mutations while running "in parallel", which violates the standard web platform concurrency model. This change moves observable state changes, internal flag updates, and promise resolution inside a queued task to ensure they are executed on the main thread.
c410b71 to
c7440ef
Compare
joeyparrish
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #585.
The setMediaKeys() algorithm in Section 7.2 of the EME specification performed several state mutations while running "in parallel", which violates the standard web platform concurrency model.
This change moves observable state changes, internal flag updates, and promise resolution inside a queued task to ensure they are executed on the main thread.
Preview | Diff