Skip to content

Conversation

@annevk
Copy link
Member

@annevk annevk commented Nov 18, 2025

And move a number of steps to happen before we go in parallel to make it easier to introduce user activation checks in the future.

We also make a couple of editorial changes that more closely aligns the language with Infra.

This helps with #346.


Preview | Diff

And move a number of steps to happen before we go in parallel to make it easier to introduce user activation checks in the future.

We also make a couple of editorial changes that more closely aligns the language with Infra.

This helps with #346.
Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Gecko will need to move the permission check after the key validation, and I assume others already do that? (With some code reading I think both WebKit and Blink do)

index.html Outdated
source=] using |global| to [=reject=] |promise| with a {{"NotAllowedError"}}
{{DOMException}} and terminate these steps.
</li>
<li>If |options|["{{PushSubscriptionOptionsInit/applicationServerKey}}"] is not non-null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we say "is null"?

@annevk annevk merged commit ebd170f into gh-pages Nov 24, 2025
2 checks passed
@annevk annevk deleted the annevk/subscribe branch November 24, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants