Code coverage and automatic publishing on npm#158
Conversation
d789a20 to
1b0d040
Compare
1b0d040 to
6660227
Compare
Code coverage and automatic publishing on npm
|
BTW, deployment will be triggered only if the build is successful, which might not happen due to CSS validator tests failing from time to time :-/ |
|
@astorije, setting up the code coverage feature was a great thing. But those automated comments from Coveralls reporting random, marginal changes after every single commit are annoying, and don't add anything but noise. Are they necessary to keep the badges up-to-date? I've been reading a bit about Coveralls, looking for options to mute the Coverall bot for our project. But didn't find any. Do you know if it's possible? Another solution would be to trigger the Coveralls job in Travis only after a new tag is created, or at least only after a PR is merged. That would keep the bot more quiet. Your thoughts? |
|
Hi @tripu! Agreed, these comments are really noisy, I wanted to ask you if you wanted to keep them or remove them today :-) Anyway, I gladly disabled the option through the settings on the coveralls website. We don't need to do anything more to keep the badge updated. Sorry I didn't do disable that in the first place. Otherwise, do you plan to create the |
|
By the way, the nice and braggy npm and license badge will be populated only after specberus makes it on npm :D |
|
Done, @astorije! I wasn't sure if we should wait to merge those two pending PRs before tagging |
|
I think it's fine, because releasing a new version is just a matter of Aren't you thrilled by your cool new badges? :D By the way, I wonder if the |
|
You working on branch |
|
Oops, sorry @tripu, I made a completion mistake and forgot to delete. Good catch, but damn you saw that fast! :-) |
|
@astorije, I have to say that I keep coming to this PR after the years, just because I seem incapable of remembering the simple sequence !! 😊 |
|
Ah, thanks for the kind words, @tripu! If you're any interested about this, I have since then moved a way a little from this model: |
rebasethis one before you woke up and so that you can merge and release without conflicts :-)npm run coverage, thanks toistanbul.coveralls, so no need to worry about this :)npm version (major|minor|patch)¹ to (a) increment by 1 the according version number, (b) commit the change of version inpackage.json, and (c) create a tag in git, calledvx.y.z.git push --follow-tags(do not rungit push --tags) to push the commit and the tag altogether, and Travis will take it from there.api_keymust be regenerated with (the lines start with a whitespace on purpose to not appear in the bash history):¹ For the next deployment, you'll want to jump directly from version
0.4.0to1.0.0. That can be done by directly runningnpm version 1.0.0.