Conversation
Member
|
I think that this is good as is, thanks! I doubt that checking the input will help that much. |
tripu
pushed a commit
that referenced
this pull request
Mar 19, 2015
Add a "transition period" feature.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@darobin, does that match what you meant?
I think I'd like to see this feature also handle changes that do not need a transition periods, if it ever happens. Do you see how we could adapt this wording to deal with that as well?
Also, do you think we need to add any check on the input, what's stored in
options(fromandtoareDateobjects,do*arefunctionvalues, ...)?Once this is final and merged, and you have reached a conclusion on spec-prod, I will use this for #155.