Add a gradient color-stops parsing test #10274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds some coverage for parsing CSS Image Values and Replaced Content Module Level 4 conic-gradient() and dual-positioned stops.
Build PASSEDStarted: 2018-04-02 19:23:42 View more information about this build on: |
Contributor
|
@LeaVerou this could use a review from you, I think. |
Contributor
Author
|
Thanks Lea! I think I also need approval from @tabatkins / @fantasai / @plinss to merge? |
Contributor
Author
|
@tabatkins @fantasai @plinss could you take a look at this? Thanks! |
emilio
approved these changes
May 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds some coverage for parsing CSS Image Values and Replaced
Content Module Level 4 conic-gradient [1] and dual-positioned stops [2].
[1] https://www.w3.org/TR/css-images-4/#conic-gradients
[2] https://www.w3.org/TR/css-images-4/#typedef-color-stop-length