Fix #2280: Update HTMLScriptElement event and htmlFor tests #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or tests Update the tests for the event and htmlFor IDL attributes of the HTMLScriptElement to expect the correct behavior: The .event and .htmlFor IDL attributes of the script element should reflect the element's "event" and "for" content attributes (respectively), and not return the empty string on getting and do nothing on setting as previously stated. See whatwg/html#253 for the related correction to the spec.
|
Critic review: https://critic.hoppipolla.co.uk/r/5915 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
jgraham
added a commit
that referenced
this pull request
Nov 3, 2015
Fix #2280: Update HTMLScriptElement event and htmlFor tests
Contributor
|
That was r+ @annevk on irc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the tests for the event and htmlFor IDL attributes of the
HTMLScriptElement to expect the correct behavior:
The .event and .htmlFor IDL attributes of the script element should reflect
the element's "event" and "for" content attributes (respectively),
and not return the empty string on getting and do nothing on setting
as previously stated.
See whatwg/html#253 for the related correction to the spec.