Mark ImageDecoderInit.data as AllowSharedBufferSource.#802
Merged
Conversation
This is what Chromium implements, but we forgot to update the spec when other data fields were changed to allow shared buffers. Fixes #799
Contributor
Author
|
ISTR the reason we expand the typedef in Chrome is just due to an IDL compiler limitation, so I left this as the unexpanded version. Let me know if you'd prefer we use the expanded version. |
Djuffin
approved these changes
Jul 17, 2024
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: fa71218 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what Chromium implements, but we forgot to update the spec when other data fields were changed to allow shared buffers.
Fixes #799
Preview | Diff