Make Send Alert Text take a string text field#889
Merged
AutomatedTester merged 3 commits intow3c:masterfrom Apr 7, 2017
andreastt:send-alert-text-json
Merged
Make Send Alert Text take a string text field#889AutomatedTester merged 3 commits intow3c:masterfrom andreastt:send-alert-text-json
AutomatedTester merged 3 commits intow3c:masterfrom
andreastt:send-alert-text-json
Conversation
shs96c
previously requested changes
Apr 7, 2017
|
|
||
| <li><p>Let <var>text</var> be the result of | ||
| joining together each item in <var>character array</var> to a string. | ||
| <a>getting the property</a> "<code>text</code>" |
Contributor
There was a problem hiding this comment.
We need to add a check that this is a string
This mirrors the changes recently made to make Element Send Keys take a string text field.
AutomatedTester
approved these changes
Apr 7, 2017
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 8, 2017
…matedtester As a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1354323, this makes the Marionette sendKeysToDialog command take a text field with a string, instead of the value field with an array of strings. The relevant WebDriver specification change is w3c/webdriver#889. Fixes: mozilla/geckodriver#607 MozReview-Commit-ID: AY52pAK2582 --HG-- extra : rebase_source : f767ae09e5f415e6e944ececfb83c442f23407f3
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 10, 2017
…matedtester a=test-only As a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1354323, this makes the Marionette sendKeysToDialog command take a text field with a string, instead of the value field with an array of strings. The relevant WebDriver specification change is w3c/webdriver#889. Fixes: mozilla/geckodriver#607 MozReview-Commit-ID: AY52pAK2582 --HG-- extra : source : 2e8560b4346891c3671e47f24675cfb1aacae6bb
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 10, 2017
…matedtester a=test-only As a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1354323, this makes the Marionette sendKeysToDialog command take a text field with a string, instead of the value field with an array of strings. The relevant WebDriver specification change is w3c/webdriver#889. Fixes: mozilla/geckodriver#607 MozReview-Commit-ID: AY52pAK2582 --HG-- extra : source : 2e8560b4346891c3671e47f24675cfb1aacae6bb extra : intermediate-source : 3d1083c028ac7444fb3c23998c830b0e849f35ee
Manishearth
pushed a commit
to Manishearth/gecko-dev
that referenced
this pull request
Apr 11, 2017
…matedtester As a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1354323, this makes the Marionette sendKeysToDialog command take a text field with a string, instead of the value field with an array of strings. The relevant WebDriver specification change is w3c/webdriver#889. Fixes: mozilla/geckodriver#607 MozReview-Commit-ID: AY52pAK2582
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Apr 12, 2017
…matedtester As a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1354323, this makes the Marionette sendKeysToDialog command take a text field with a string, instead of the value field with an array of strings. The relevant WebDriver specification change is w3c/webdriver#889. Fixes: mozilla/geckodriver#607 MozReview-Commit-ID: AY52pAK2582
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…matedtester As a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1354323, this makes the Marionette sendKeysToDialog command take a text field with a string, instead of the value field with an array of strings. The relevant WebDriver specification change is w3c/webdriver#889. Fixes: mozilla/geckodriver#607 MozReview-Commit-ID: AY52pAK2582 UltraBlame original commit: 2e8560b4346891c3671e47f24675cfb1aacae6bb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…matedtester As a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1354323, this makes the Marionette sendKeysToDialog command take a text field with a string, instead of the value field with an array of strings. The relevant WebDriver specification change is w3c/webdriver#889. Fixes: mozilla/geckodriver#607 MozReview-Commit-ID: AY52pAK2582 UltraBlame original commit: 2e8560b4346891c3671e47f24675cfb1aacae6bb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…matedtester As a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1354323, this makes the Marionette sendKeysToDialog command take a text field with a string, instead of the value field with an array of strings. The relevant WebDriver specification change is w3c/webdriver#889. Fixes: mozilla/geckodriver#607 MozReview-Commit-ID: AY52pAK2582 UltraBlame original commit: 2e8560b4346891c3671e47f24675cfb1aacae6bb
sergiotarxz
pushed a commit
to sergiotarxz/JapacharBrowser
that referenced
this pull request
Mar 23, 2026
…matedtester As a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1354323, this makes the Marionette sendKeysToDialog command take a text field with a string, instead of the value field with an array of strings. The relevant WebDriver specification change is w3c/webdriver#889. Fixes: mozilla/geckodriver#607 MozReview-Commit-ID: AY52pAK2582
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is