Take <select multiple> into account in obscured element test#894
Merged
shs96c merged 1 commit intow3c:masterfrom Apr 19, 2017
andreastt:obscured-select-multiple
Merged
Take <select multiple> into account in obscured element test#894shs96c merged 1 commit intow3c:masterfrom andreastt:obscured-select-multiple
shs96c merged 1 commit intow3c:masterfrom
andreastt:obscured-select-multiple
Conversation
As the options of a <select multiple> are painted and represented as DOM elements, the center point would end up targetting one of the <option> elements. We can take this into account by using select.contains(option). If the first pointer-interactable paint tree element is itself, this is also passes the check, since the DOMElement.contains(otherEl) performs an _inclusive_ descendant check. This means element.contains(element) is true.
Contributor
|
I _ think_ this makes sense. Will correct the typos once the merge is in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the options of a
<select multiple>are painted and represented as DOMelements, the center point would end up targetting one of the
<option>elements. We can take this into account by using
select.contains(option).If the first pointer-interactable paint tree element is itself, this is
also passes the check, since the
DOMElement.contains(otherEl)performsan inclusive descendant check. This means
element.contains(element)is true.
This change is