Test in view with pointer events enabled#896
Merged
shs96c merged 1 commit intow3c:masterfrom Apr 19, 2017
andreastt:pointer-events-none-in-view
Merged
Test in view with pointer events enabled#896shs96c merged 1 commit intow3c:masterfrom andreastt:pointer-events-none-in-view
shs96c merged 1 commit intow3c:masterfrom
andreastt:pointer-events-none-in-view
Conversation
When an element has pointer events disabled, e.g. <input type=button style="pointer-events: none">, it does not appear in the paint tree acquired from document.elementsFromPoint. To circumvent this issue and make element in view checks possible for elements which don’t have pointer events enabled, we need to run the check as if pointer events were enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an element has pointer events disabled, e.g.
<input type=button style="pointer-events: none">,it does not appear in the paint tree acquired from
document.elementsFromPoint.To circumvent this issue and make element in view checks possible for
elements which don’t have pointer events enabled, we need to run the
check as if pointer events were enabled.
This change is