Here Are my Edits to the group sorter project. #249
Conversation
Here are my edits for the groups-sorter app, along with its other dependencies such as the extra icons and added css and javascript. I created a new UI design for the sorter application. So, now, the user can click on a subject and it'll bring the time groups up on separate columns. One column for Full Time, and the other for Part Time. Please, take a look at the differences and review. Also, feel free to add or take what you may to make this a better version. :)
ghost
requested review from
JonDevOps
left a comment
JonDevOps
left a comment
There was a problem hiding this comment.
Everything looks great I am approving this commit.
hannahpi
left a comment
hannahpi
left a comment
There was a problem hiding this comment.
I know I'm late as this has already been merged. Overall it looks good. I'm not too keen on reviewing css from looking at code but everything else looks good. Hopefully we can identify why github picked up changes on all lines of these files and prevent that in the future. You might want to check settings and see if there's a setting to conserve current line endings in your editor.
Thanks for your contribution!
| margin-bottom: 50px; | ||
| font-family: Montserrat, "Helvetica Neue", Helvetica, Arial, sans-serif; | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not sure why github is picking up diffs on all these files when no changes have been made. I'm wondering if you may have inadvertently switched line endings, that's the only invisible character I would expect here that would cause a change on all these files. If it's necessary great, In the future I would prefer it to be in a different PR so it's easier to sort out the changes.
| } | ||
|
|
||
| </script> | ||
| <!-- 6/9/2019 Chris L: Created an external js file in the js folder, Script to sort study groups--> |
There was a problem hiding this comment.
This comment probably belongs in the pull request rather than in the file or the commit messages to make it easier to review what was done. The note that it's a script for sorting study groups is fine though so either way.
3 participants
Here are my edits for the groups-sorter app, along with its other dependencies such as the extra icons and added css and javascript. I created a new UI design for the sorter application. So, now, the user can click on a subject and it'll bring the time groups up on separate columns. One column for Full Time, and the other for Part Time. Please, take a look at the differences and review. Also, feel free to add or take what you may to make this a better version. :)
edit this
Update index.md)masterbranch of freeCodeCamp.Closes #XXXXX