Skip to content

Add mapping for the xml:lang attribute in Atom feeds #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
w3stling merged 2 commits into from
Nov 15, 2025
Merged

Add mapping for the xml:lang attribute in Atom feeds #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ca8da5
Map xml:lang on Atom feed
w3stling Nov 15, 2025
1f2f495
Fix test
w3stling Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/apptasticsoftware/rssreader/AbstractRssReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ protected void registerChannelTags() {
* Register channel attributes for mapping to channel object fields
*/
protected void registerChannelAttributes() {
channelAttributes.computeIfAbsent("/feed", k -> new HashMap<>()).put("lang", Channel::setLanguage);
channelAttributes.computeIfAbsent("link", k -> new HashMap<>()).put("href", Channel::setLink);
channelAttributes.computeIfAbsent("category", k -> new HashMap<>()).putIfAbsent("term", Channel::addCategory);
}
Expand Down
10 changes: 9 additions & 1 deletion src/test/java/com/apptasticsoftware/integrationtest/RssReaderIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ void rssScb() throws IOException {
assertNotNull(channel);
assertThat(channel.getTitle(), is("Statistiska centralbyrån - Statistiknyheter"));
assertThat(channel.getDescription(), is("Statistiknyheter via RSS"));
assertThat(channel.getLanguage(), isEmpty());
assertThat(channel.getLanguage(), isPresentAndIs("sv-SE"));
assertThat(channel.getLink().toLowerCase(), is("http://www.scb.se/feed/statistiknyheter/"));
assertThat(channel.getCopyright(), isEmpty());
assertThat(channel.getGenerator(), isEmpty());
Expand Down Expand Up @@ -811,6 +811,14 @@ void multipleChanelDescriptionOnDifferentLevels() {
assertEquals("NYT > image description", item.getChannel().getImage().map(image -> image.getDescription().orElse("")).orElse(""));
}

@Test
void atomFeedWithLanguage() {
var list = new RssReader().read(fromFile("item-sort-test.xml"))
.collect(Collectors.toList());
assertEquals(10, list.size());
assertEquals("en", list.get(0).getChannel().getLanguage().orElse(""));
}

@Test
void atomFeedWithCategory() {
var list = new RssReader().read(fromFile("atom-feed-category.xml"))
Expand Down