Updated docker-compose examples #104
Conversation
stappersg
left a comment
stappersg
left a comment
There was a problem hiding this comment.
The additions are good, the changes not so good.
| - -d /tmp/rgit-cache.db | ||
| volumes: | ||
| - /path/to/my-repos:/git | ||
| - /volume/git:/git |
There was a problem hiding this comment.
It's going to be different for each environment, so the difference between the two paths is completely inconsequential. /volume doesn't exist in a standard environment, and either does /path/to/my-repos, so there's no danger of exposing anything here.
I don't understand your gripe.
| - /volume/git:/git | ||
| ports: | ||
| - 3333:8000 | ||
| - 8000:8000 |
There was a problem hiding this comment.
Ports shouldn't be exposed at all in a docker environment--but this is how people use docker, and is the way that the original docker-composer.yml file was to begin with. Yet again, it's going to depend on the end-users environment, so using 3333:8000 is tentatively identical to 8000:8000.
3333 interferes with NCID servers on the host machine, and 8000 interferes with some database servers. There's effectively nothing you can set it to that won't interfere with something, so again, I really don't understand the gripe here. They're both non-privileged ports.
|
On Fri, Mar 14, 2025 at 01:55:31PM -0700, Zach Queal wrote:
> volumes:
- - /path/to/my-repos:/git
+ - /volume/git:/git
It's going to be different for each environment, so the difference
between the two paths is completely inconsequential. `/volume` doesn't
exist in a standard environment, and either does `/path/to/my-repos`,
so there's no danger of exposing anything here.
I don't understand your gripe.
It is the "I change this just because I can" that I oppose.
Do know that my message is: The merge request got human attention.
Groeten
Geert Stappers
--
Silence is hard to parse
|
|
So then don't merge it? I still, again and again, fail to see the issue. Fact of the matter is, is that the docker example that's currently in this repository doesn't work. So it kinda is what it is. Update it or don't. 🤷🏻♂️ |
|
On Sat, Mar 15, 2025 at 11:29:03PM -0700, Zach Queal wrote:
zQueal left a comment (w4/rgit#104)
So then don't merge it? I still, again and again, fail to see the
issue. Fact of the matter is, is that the docker example that's
currently in this repository doesn't work.
Other facts:
- This merge request was closed by the person who opened it
- Project lead has expressed several times
"I don't use rgit under docker"
So it kinda is what it is.
True
Update it or don't.
Proposing another merge request makes updating possible.
Groeten
Geert Stappers
Not the rgit project lead
--
Silence is hard to parse
|
|
Hi @zQueal, thanks for your contribution. Looks perfectly fine to me. Ignore the argumentative other commenter, just a random member of the public that added a favicon 😄 |
|
Appreciate the work man, love this project! |
|
On Sun, Mar 16, 2025 at 02:44:15PM -0700, Zach Queal wrote:
Appreciate the work man, love this project!
Yes, w4/rgit is a cool project.
Hence my reason for making merge request #106.
Because I have "watch all" activated, did I saw also #130.
What is your position on the patch?
Regards
Geert Stappers
Doesn't use rgit under docker,
asking rgit docker user for help for the sake of the project
--
Silence is hard to parse
|
3 participants
Updated docker-compose examples for what works out of the box.