Skip to content

fix: address CodeRabbit findings from the v0.2.14 release review (#205)#209

Merged
w7-mgfcode merged 11 commits into
devfrom
fix/coderabbit-v0214-review-findings
May 18, 2026
Merged

fix: address CodeRabbit findings from the v0.2.14 release review (#205)#209
w7-mgfcode merged 11 commits into
devfrom
fix/coderabbit-v0214-review-findings

Conversation

@w7-mgfcode
Copy link
Copy Markdown
Owner

Summary

Addresses the 32 valid CodeRabbit findings from the v0.2.14 release review (#201), tracked in #205. One commit per theme.

Closes #205.

Themes

# Theme Commit scope
1 Deterministic pagination — unique tie-breaker sort key on dimensions / jobs / registry list endpoints fix(api)
2 Test isolation — scope teardown deletes to TEST-% rows, pop(get_db) over clear(), restore mutated Settings singleton in finally test(api)
3 URL query-param validation — new lib/url-params.ts (parsePageParam / parseIdParam / parseEnumParam) applied across sales / runs / stores / products / jobs fix(ui)
4 Job-cancel — wrap mutateAsync in try/catch + surface a toast fix(ui)
5 Dynamic chart height — inline style instead of a non-discoverable h-[${height}px] class fix(ui)
6 Keyboard accessibility — tabIndex/role/onKeyDown on clickable rows and sort headers; getVisibleLeafColumns() for skeleton/empty colSpan fix(ui)
7 Demand planner — Math.ceil reorder qty; pick latest inventory snapshot by date fix(ui)
8 RFC 7807 — validate_date_range raises BadRequestError so all three analytics endpoints emit application/problem+json; ge=1 on store_id/product_id fix(analytics)
9 CSV formula injection — neutralize =/+/-/@/control-char-leading values in quoteField fix(ui)
Misc — Array.isArray guard on forecast results, config-error state on the Agent Guide, backtest form n_splits>=2/test_size>=1, use-inventory barrel re-export, shared default_seed_end_date() in run_demo.py fix(ui) / fix(data)

Tests

New regression tests: url-params.test.ts, CSV-injection + demand-rounding/inventory-by-date cases.

Validation

  • ruff check / ruff format --check — pass
  • mypy --strict / pyright --strict — pass (0 errors)
  • pytest -m "not integration" — 1105 passed
  • pytest -m integration (analytics/dimensions/jobs/config) — 30 passed
  • pnpm tsc --noEmit / pnpm lint (0 errors) / pnpm test — 54 passed

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @w7-mgfcode, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e14b169a-4eb8-4b61-9cca-dd32cbf67bb4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/coderabbit-v0214-review-findings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@w7-mgfcode w7-mgfcode merged commit 2045811 into dev May 18, 2026
8 checks passed
@w7-mgfcode w7-mgfcode deleted the fix/coderabbit-v0214-review-findings branch May 20, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant