Skip to content

Handle spacing grapheme extenders U+FF9E-U+FF9F#294

Merged
waf merged 1 commit into
mainfrom
spacing-grapheme-extenders
Jun 7, 2026
Merged

Handle spacing grapheme extenders U+FF9E-U+FF9F#294
waf merged 1 commit into
mainfrom
spacing-grapheme-extenders

Conversation

@waf
Copy link
Copy Markdown
Owner

@waf waf commented Jun 7, 2026

More fixes around #270

U+FF9E/U+FF9F (halfwidth katakana voiced / semi-voiced sound marks) have Grapheme_Cluster_Break = Extend, so StringInfo groups each into its preceding kana (ハ+゚ = one cluster). But unlike a normal combining mark that overlays its base (zero width), these are spacing marks (category Lm, wcwidth = 1) that take their own halfwidth cell

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 7, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.5%. Comparing base (de35496) to head (7c3c644).

Files with missing lines Patch % Lines
src/PrettyPrompt/Rendering/UnicodeWidth.cs 85.7% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #294   +/-   ##
=====================================
  Coverage   84.5%   84.5%           
=====================================
  Files         47      47           
  Lines       3972    3977    +5     
  Branches     664     666    +2     
=====================================
+ Hits        3357    3363    +6     
  Misses       452     452           
+ Partials     163     162    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@waf waf merged commit 1708d56 into main Jun 7, 2026
2 checks passed
@waf waf deleted the spacing-grapheme-extenders branch June 7, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant