fix: build the action with rollup #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagoid
force-pushed
the
fix/build-the-action-with-rollup
branch
from
87872cb to
c54451d
Compare
On v4, we used the default nodejs resolution logic to allow ES modules in dependencies. This created a breaking change of forcing users of this action to use the .cjs extension instead of .js in config files. With this fix, we now bundle the action with rollup to allow ES modules in dependencies, while keeping the support for .js config files. With this change, the default config file was returned back to .js instead of .cjs. Fixes #194
wagoid
force-pushed
the
fix/build-the-action-with-rollup
branch
from
c54451d to
2e57812
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On v4, we used the default nodejs resolution logic to allow ES modules in dependencies.
This created a breaking change of forcing users of this action
to use the .cjs extension instead of .js in config files.
With this fix, we now bundle the action with rollup to allow ES modules
in dependencies, while keeping the support for .js config files.
Fixes #194